1

Resolved

Update fails for download URLs with special characters (with fix)

description

Hi there,

if the Download-URL contains URL-parameters like
https://my.domain/my/api/download/MyProgram?status=release
then the automatic update fails because NetSparkle tries to download to a file named
MyProgram?status=release 
in the temp directory (which is obviously not a valid Windows-filename)

I attached a corrected NetSparkleDownloadProgress.cs file which
  1. chops everthing after the "?" if the url contains one
  2. adds a (default) .msi extension if no extension is provided

file attachments

comments

u8i wrote Aug 5, 2013 at 3:42 PM

I added two more optimizations
  1. Sanitize filename
  2. If file exists append a timestamp to the filename